Conversation

Notices

1. MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 18:53:08 UTC MMN-o ✅⃠

   • Manuel Ortega
   Btw, this regex (in your commit link above) seems faulty:
   if(!preg_match('/(\share)$/i', $ero->activity->verb)) {
   
   I think you meant \/share instead of \share :)
   • @mcscx@quitter.se likes this.
   • MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 09:56:27 UTC MMN-o ✅⃠

     • Manuel Ortega
     @manuel I think so. I would want repeats included at least. (consider if you want to recreate a conversation on a remote site, you'd want to see who has repeated stuff too)
   • MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 12:02:40 UTC MMN-o ✅⃠

     • Manuel Ortega
     @manuel Which feed are you using for this? I would recommend looking at the "verb" of the post. Give me a link to a feed and I'll see if you have all that's necessary (or I'll add it)
   • MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 12:13:22 UTC MMN-o ✅⃠

     • Manuel Ortega
     You can see that:
     <activity:verb>http://activitystrea.ms/schema/1.0/share</activity:verb>
     
     is always "[...]/share" on a repeat. On everything that you're interested to see in the comments feed, it will have:
     
     <activity:verb>http://activitystrea.ms/schema/1.0/post</activity:verb>
     
     instead ([...]/post).
     
     Is it ok to filter on that?
   • MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 12:14:20 UTC MMN-o ✅⃠

     in reply to

     • Manuel Ortega
     @manuel Btw if there is _no_ <activity:verb> element it defaults to a "post" verb :)
   • MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 12:18:23 UTC MMN-o ✅⃠

     • Manuel Ortega
     @manuel Implementado ahorita!!!
   • MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 18:49:35 UTC MMN-o ✅⃠

     • Manuel Ortega
     @manuel It _is_ actually a share verb! But it _contains_ a post verb ;) Only compare the "top" verb in the hierarchy :)
     I think you may be comparing at the element. The structure is (greatly simplified) as this: https://social.umeahackerspace.se/attachment/56427
   • MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Friday, 26-Feb-2016 18:55:34 UTC MMN-o ✅⃠

     in reply to

     • Manuel Ortega
     ^- @manuel After looking at your code, I think you only have to fix the regex! Right now you will never match the share verb. See this post's parent for the solution.