Conversation

Notices

1. raboof@merveilles.town's status on Thursday, 26-May-2022 07:06:09 UTC raboof

   in reply to

   • tmd

   @tumdum I guess 'it depends' :D - for 'clearly this should have been different in the first place' amending makes sense, but for 'this alternate way of doing things is superior' or 'this additional thing is needed as well' separate commits can be nice.

   If the contribution already consists of multiple commits and the change 'belongs' to one of the 'earlier' commits, going back and amending that commit might not be worth it. Might make sense to squash the whole thing though :D

   • Santa Claes 🇸🇪🇭🇰🎅 likes this.
   • tmd (tumdum@icosahedron.website)'s status on Thursday, 26-May-2022 07:06:15 UTC tmd

     in reply to

     @raboof I was under the impression that the “proper” way to deal with review comments is to amend existing commit(s) that should have contained the requested change. Not that I do that ;)

   • raboof@merveilles.town's status on Thursday, 26-May-2022 07:06:16 UTC raboof

     (squashing some 'wip' commits before publishing the contribution is still useful of course, but 'address review comment X'-style commits, that I used to squash on merge, now seem worth keeping)