Conversation

Notices

1. Hallå Kitteh (clacke@social.heldscal.la)'s status on Wednesday, 10-Jan-2018 12:14:22 UTC Hallå Kitteh

   • Dave Morriss
   • Bob Mottram
   • Lars Wirzenius
   @bob @liw Another advantage of PRs is that they are easy for a third party to observe and comment on, whereas a patch would reside in private mail or at best a mailing list.
   
   @perloid or Ken commented on one of the two latest monthly HPR Community News that putting things in issues (which is part of what a PR is, even if they are two different things in the GH interface) rather than a mailing list helps with keeping track on what's done and not.
   
   I 100% agree with the observation that GitHub is problematic and GitLab is somewhat problematic. I would say though that GitLab includes a whole lot of things in the fully-free version, and what was missing last time I checked (literally years ago though) was basically things like integration with an existing enterprise authn/authz system. Gitea/Gogs does not have this issue, but not by having that functionality in the free version, rather by there not existing a non-free add-on, so I don't know if that is really an improvement for this particular issue.
   
   As for distributed PRs and issue tracking, the only system I am aware of is git-ssb[0], which does it by living on top of an already distributed messaging system, secure-scuttlebutt[1].
   
   [0] https://git-ssb.celehner.com/%25n92DiQh7ietE%2BR%2BX%2FI403LQoyf2DtR3WQfCkDKlheQU%3D.sha256
   [1] https://www.scuttlebutt.nz/
   • Lars Wirzenius (liw@mastodon.acc.sunet.se)'s status on Tuesday, 09-Jan-2018 16:13:38 UTC Lars Wirzenius

     https://blog.liw.fi/posts/2018/01/09/on_using_github_and_a_pr_based_workflow/

     I tried PRs and I didn't like it.

     Hallå Kitteh repeated this.
   • Hallå Kitteh (clacke@social.heldscal.la)'s status on Wednesday, 10-Jan-2018 12:16:04 UTC Hallå Kitteh

     in reply to

     • Bob Mottram
     • Lars Wirzenius
     @liw @bob
     
     > especially the emails Github sends about PRs seemed useless beyond a basic "something happened" notification, which prompt me to check the web UI
     
     Sadly the typical flaw of a place like github that is more corporate social network than collaboration tool. Gotta get those page views and that engagement. No incentive to improve ways of living outside the web page.
   • Hallå Kitteh (clacke@social.heldscal.la)'s status on Wednesday, 10-Jan-2018 12:18:40 UTC Hallå Kitteh

     in reply to

     • Bob Mottram
     • Lars Wirzenius
     @liw @bob
     
     > merging a PR is perhaps too easy, and I worry that it leads me to merging without sufficient review (that is of course a personal flaw)
     
     Integration with build bots that can comment directly on the PR with automated test results probably helps a lot with reducing this potential issue. There are several available, free software and not, which are usually provided free of charge for free software.
     
     GitLab has bundled CI support as well, free of charge for free and non-free, public and private, users on their centralized instance.